Fix detection of RUN_ARM64_TESTS in Windows test jobs #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Nov 24, 2022
Signed-off-by: Stewart X Addison <sxa@redhat.com>
sxa
force-pushed
the
fix_arm64_testing
branch
from
19cc5c9 to
3a0ac4d
Compare
richardlau
approved these changes
Nov 24, 2022
AshCripps
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preventing correct detection of when the RUN_ARM64_TESTS is checked in https://ci.nodejs.org/job/node-test-binary-windows-js-suites/ similar to the changes we had to make in https://github.com/nodejs/build/pull/3019/files when updating the version of java on the server.
Without this change you get this error because the value is a byte array
[116, 114, 117, 101].regardless of whether the box is checked.
Signed-off-by: Stewart X Addison sxa@redhat.com